walterddr commented on code in PR #12293:
URL: https://github.com/apache/pinot/pull/12293#discussion_r1462673614
##########
pinot-common/src/test/java/org/apache/pinot/common/function/FunctionDefinitionRegistryTest.java:
##########
@@ -43,7 +43,7 @@ public class FunctionDefinitionRegistryTest {
// Geo functions are defined in pinot-core
"geotoh3",
// ArrayToMV and ArrayValueConstructor are placeholder functions without
implementation
- "arraytomv", "arrayvalueconstructor",
+ "arraytomv", "arrayvalueconstructor", "arraygenerate",
Review Comment:
can we also update the comment ^
##########
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##########
@@ -271,6 +271,7 @@ public enum TransformFunctionType {
OperandTypes.family(ImmutableList.of(SqlTypeFamily.ARRAY)),
"vector_norm"),
ARRAY_VALUE_CONSTRUCTOR("arrayValueConstructor", "array_value_constructor"),
+ ARRAY_GENERATE("arrayGenerate", "array_generate"),
Review Comment:
what's the goal we want to achieve here? ARRAY_GENERATE unlike
ARRAY_VALUE_CONSTRUCTOR is not a SqlStdOperatorTable entry so it will not work
with multi-stage simply by adding this alone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
