Jackie-Jiang commented on code in PR #12290: URL: https://github.com/apache/pinot/pull/12290#discussion_r1462413055
########## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java: ########## @@ -87,6 +87,7 @@ public static DimensionTableDataManager getInstanceByTableName(String tableNameW private final AtomicInteger _loadToken = new AtomicInteger(); private boolean _disablePreload = false; + private boolean _disallowDuplicatePrimaryKey = false; Review Comment: Still suggest naming it `_errorOnDuplicatePrimaryKey`. We shouldn't allow duplicate primary key in any case since it will result in inconsistent behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
