gortiz commented on code in PR #12218: URL: https://github.com/apache/pinot/pull/12218#discussion_r1457039663
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/ForwardIndexConfig.java: ########## @@ -99,6 +171,8 @@ public int hashCode() { } public static class Builder { + @Nullable + private CompressionCodec _compressionCodec; Review Comment: I didn't want to remove them to keep backward compatibility, but I guess we didn't actually release a stable version with `chunkCompressionType` `dictIdCompressionType` so we may not need to worry about that. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org