klsince commented on code in PR #11851:
URL: https://github.com/apache/pinot/pull/11851#discussion_r1453904643
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/instance/InstanceDataManagerConfig.java:
##########
@@ -68,4 +68,10 @@ public interface InstanceDataManagerConfig {
long getExternalViewDroppedMaxWaitMs();
long getExternalViewDroppedCheckIntervalMs();
+
+ String getUpsertDefaultMetadataManagerClass();
Review Comment:
how about add `Map<String, String> getUpsertConfigs()` here and return
_instanceDataManagerConfiguration.subset("upsert") in
HelixInstanceDataManagerConfig.java
so that we can keep those upsert specific configs to be defined inside the
BaseTableUpsertMetadataManager, who should know what upsert specific configs it
needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
