walterddr commented on code in PR #12237: URL: https://github.com/apache/pinot/pull/12237#discussion_r1445500680
########## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotSortExchangeCopyRule.java: ########## @@ -42,6 +42,7 @@ public class PinotSortExchangeCopyRule extends RelRule<RelRule.Config> { public static final PinotSortExchangeCopyRule SORT_EXCHANGE_COPY = PinotSortExchangeCopyRule.Config.DEFAULT.toRule(); + private static final int DEFAULT_SORT_EXCHANGE_COPY_THRESHOLD = 10_000; Review Comment: probably. but i haven't decided whether to use a hint or use a query param. so for now i will keep this as a default and if we need to support configuration we will do that then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org