walterddr commented on code in PR #12194:
URL: https://github.com/apache/pinot/pull/12194#discussion_r1439696608
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/controller/PinotControllerTransport.java:
##########
@@ -51,14 +49,14 @@ public class PinotControllerTransport {
private final String _scheme;
private final AsyncHttpClient _httpClient;
- public PinotControllerTransport(Map<String, String> headers, String scheme,
@Nullable SSLContext sslContext,
+ public PinotControllerTransport(Map<String, String> headers, String scheme,
@Nullable SslContext sslContext,
ConnectionTimeouts connectionTimeouts, TlsProtocols tlsProtocols,
@Nullable String appId) {
Review Comment:
since this is public API we might need to keep supporting both
javax.net.ssl.SSLContext and io.netty.handler.ssl.SslContext and mark the
former with deprecated annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
