cypherean commented on PR #12201: URL: https://github.com/apache/pinot/pull/12201#issuecomment-1868537068
@Jackie-Jiang comments on linked PR #11850 - > These are not common functions, and I find them quite hard to read. Can we keep it simple? It is okay if we need to repeat some code done > Query param should be tableName done > Shall we keep it consistent with other APIs where optional field is represented as @Nullable the default value for optional query params is "", and setting a custom default value also only takes a string > I think we want to put hosts when table exists, even if it is empty done > This tableName can be raw (without type suffix). The returned map should contain the actual table name with type suffix done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
