KKcorps commented on code in PR #12195:
URL: https://github.com/apache/pinot/pull/12195#discussion_r1434655645
##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConnectionHandler.java:
##########
@@ -73,10 +73,10 @@ public PulsarPartitionLevelConnectionHandler(String
clientId, StreamConfig strea
}
}
- private Optional<Authentication> getAuthenticationFactory(PulsarConfig
pulsarConfig) {
+ protected Optional<Authentication> getAuthenticationFactory(PulsarConfig
pulsarConfig) {
Review Comment:
If this scope is changed just for testing, can we add @VisibleForTesting
annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
