saurabhd336 commented on PR #12039: URL: https://github.com/apache/pinot/pull/12039#issuecomment-1859227188
> We probably want to separate the tenant config for brokers and servers. Since the tag is different, we may consider applying config based on instance tag. We may use `pinot.tag.<tagName>.<config>`, where `pinot.tag.<tagName>` will be replaced to `pinot.broker` or `pinot.server` Sorry I don't follow. Right now I had only added support for overriding server conf for servers tagged with a specific tenant. Your suggestion is to 1) Allow overriding conf for all components (servers, brokers, controllers, minions) 2) Use instance tag instead of tenant name for the override Is this correct? #1 makes sense to me, I'll add the changes to support all components. #2, I'm not sure why using tenant names directly for the override would not work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
