timveil commented on code in PR #12130:
URL: https://github.com/apache/pinot/pull/12130#discussion_r1424689833
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/RangeIndexCreator.java:
##########
@@ -321,6 +322,7 @@ public void seal()
try (BufferedOutputStream bos = new BufferedOutputStream(new
FileOutputStream(_rangeIndexFile));
DataOutputStream header = new DataOutputStream(bos);
FileOutputStream fos = new FileOutputStream(_rangeIndexFile);
+ FileChannel channel = fos.getChannel();
Review Comment:
you are right. i try to be good about closing these things as its easy to
miss and IntelliJ makes a fuss if you dont.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
