walterddr commented on issue #12057: URL: https://github.com/apache/pinot/issues/12057#issuecomment-1843900336
I see. i think one misconception is this deals with more than just what multi-stage is doing: e.g. 1. not only the group-key is partitioned, thus the agg can directly return final result on each group 2. but also if the aggregate operand is by itself partitioned, the agg function can produce another form of merge-able format that's not as complex as normal IntermediateResult. in this sense, i agree with @Jackie-Jiang's comment above. The only thing I want to call out is that the `boolean isPartitionedAggregation()` is confusing. b/c it doesn't clearly tell whether it meant scenario (1) or (2) for the above. I think a way to clearly indicate whether the result of the aggregate is "partitionResult" or "finalResult" would be more desirable (after all that's the goal of the flag is for yes?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
