abhioncbr commented on code in PR #11985:
URL: https://github.com/apache/pinot/pull/11985#discussion_r1414394951
##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java:
##########
@@ -317,19 +242,57 @@ public static String
recoverSpecialCharacterInPropertyValue(String value) {
return value.replace("\0\0", ",");
}
+ /**
Review Comment:
Moved the function
[getStringListFromSegmentProperties](https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/LoaderUtils.java#L70C30-L70C64)
to here, since commons-configuration2 saves list-based data individually, for
exampel
```bash
segment.dimension.column.names = bytesDimSV1
segment.dimension.column.names = generationNumber
segment.dimension.column.names = intDimMV1
segment.dimension.column.names = intDimMV2
segment.dimension.column.names = longDimSV1
segment.dimension.column.names = longDimSV2
segment.dimension.column.names = mapDim1__KEYS
segment.dimension.column.names = mapDim1__VALUES
segment.dimension.column.names = mapDim2json
segment.dimension.column.names = stringDimMV1
segment.dimension.column.names = stringDimMV2
segment.dimension.column.names = stringDimSV1
segment.dimension.column.names = stringDimSV2
segment.dimension.column.names = textDim1
segment.metric.column.names = doubleMetric1
segment.metric.column.names = floatMetric1
segment.metric.column.names = intMetric1
segment.metric.column.names = longMetric1
```
to make this migration compatible, enhanced the function to split the values
in-case if it has comma `,`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
