zhtaoxiang commented on code in PR #12090:
URL: https://github.com/apache/pinot/pull/12090#discussion_r1414356699
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -158,6 +158,15 @@ protected String getKafkaZKAddress() {
return getZkUrl() + "/kafka";
}
+ /**
Review Comment:
The same for changes in this class.
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -123,22 +123,41 @@ public class ControllerTest {
private int _controllerPort;
private String _controllerBaseApiUrl;
+ private final Map<Integer, String> _controllerBaseApiUrls = new HashMap<>();
Review Comment:
Instead of modifying the existing `ControllerTest`, can we create another
separate class `MultipleControllerTest`? This can keep the existing code easy
to read
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -397,9 +406,8 @@ protected Map<String, String>
getCSVDecoderProperties(@Nullable String delimiter
/**
* Creates a new Upsert enabled table config.
*/
- protected TableConfig createCSVUpsertTableConfig(String tableName, @Nullable
String kafkaTopicName,
- int numPartitions, Map<String, String> streamDecoderProperties,
UpsertConfig upsertConfig,
- String primaryKeyColumn) {
+ protected TableConfig createCSVUpsertTableConfig(String tableName, @Nullable
String kafkaTopicName, int numPartitions,
Review Comment:
Can we please do not reformat unrelated code? reformatting makes the code
harder to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
