klsince commented on code in PR #11978:
URL: https://github.com/apache/pinot/pull/11978#discussion_r1408554417
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java:
##########
@@ -152,7 +189,40 @@ public Map<ServerInstance, List<String>>
getRoutingTableForQuery(
@ApiParam(value = "SQL query (table name should have type suffix)")
@QueryParam("query") String query,
@Context HttpHeaders httpHeaders) {
BrokerRequest brokerRequest =
CalciteSqlCompiler.compileToBrokerRequest(query);
+ checkAccessControl(brokerRequest, httpHeaders);
+ RoutingTable routingTable = _routingManager.getRoutingTable(brokerRequest,
getRequestId());
+ if (routingTable != null) {
+ return
removeOptionalSegments(routingTable.getServerInstanceToSegmentsMap());
+ } else {
+ throw new WebApplicationException("Cannot find routing for query: " +
query, Response.Status.NOT_FOUND);
+ }
+ }
+
+ @GET
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("/debug/routingTableWithOptionalSegments/sql")
+ @ManualAuthorization
+ @ApiOperation(value = "Get the routing table for a query, including optional
segments")
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Routing table"),
+ @ApiResponse(code = 404, message = "Routing not found"),
+ @ApiResponse(code = 500, message = "Internal server error")
+ })
+ public Map<ServerInstance, Pair<List<String>, List<String>>>
getRoutingTableForQueryWithOptionalSegments(
+ @ApiParam(value = "SQL query (table name should have type suffix)")
@QueryParam("query") String query,
+ @Context HttpHeaders httpHeaders) {
+ Map<ServerInstance, Pair<List<String>, List<String>>> result;
Review Comment:
sharp eye
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
