xiangfu0 commented on code in PR #11993:
URL: https://github.com/apache/pinot/pull/11993#discussion_r1406858182
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/ForwardIndexConfig.java:
##########
@@ -65,25 +70,32 @@ public int getRawIndexWriterVersion() {
return _rawIndexWriterVersion;
}
+ @Nullable
+ public DictCompressionType getDictCompressionType() {
Review Comment:
Not sure if this is the right thing, feeling we shouldn't leak abstraction
of dictionary to forward index?
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/ForwardIndexConfig.java:
##########
@@ -65,25 +70,32 @@ public int getRawIndexWriterVersion() {
return _rawIndexWriterVersion;
}
+ @Nullable
+ public DictCompressionType getDictCompressionType() {
Review Comment:
Not sure if this is the right, feeling we shouldn't leak abstraction of
dictionary to forward index?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
