Nemesis123925 opened a new pull request, #12048: URL: https://github.com/apache/pinot/pull/12048
After the this [PR](https://github.com/apache/pinot/pull/11941), I continue to explore how to fix the unfixed test by that PR. In this [section](https://github.com/apache/pinot/pull/11941#issuecomment-1811542285), I said that [reduceOnDataTable](https://github.com/Nemesis123925/pinot/blob/master/pinot-core/src/test/java/org/apache/pinot/queries/ExplainPlanQueriesTest.java#L416) might be contributing to the non-determinism inside of the `numSegmentsForThisPlan`. But that's not the only cause. After exploring, I found that when nonDex is applied, the two `queries` generated by the two `servers` might be completely differet. There is once that the produced and selected `queries` only have two rows inside. So here I resubmit the initial commit that I did on the previous PR, because the non-determinism inside these tests can actually cause more trouble that can not be solved by sorting the `PROJECT` field. While the initial commit completely solve the non-determinism, it also cause the code coverage to change, and a test from other class to fail. By Opening this PR, I hope to reexplore the possibility to modifiy on my original commit, to make it has less code coverage changes and no other test failures, because this way completely sove the root of non-determinism instead of just changing it only in the test part. At the same time, I hope to communicate with @somandal, who is expert in this field, to talk about the possibility of using other fixs to eliminiate the non-determinism. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
