Jackie-Jiang commented on code in PR #11849:
URL: https://github.com/apache/pinot/pull/11849#discussion_r1391951285
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -100,9 +103,9 @@ private static class IngestionTimestamps {
// ideal state. This is done with the goal of minimizing reading ideal state
for efficiency reasons.
private final Map<Integer, Long> _partitionsMarkedForVerification = new
ConcurrentHashMap<>();
- final int _timerThreadTickIntervalMs;
- // Timer task to check partitions that are inactive against ideal state.
- private final Timer _timer;
+ final int _scheduledExecutorThreadTickIntervalMs;
+ // ScheduledExecutorService to check partitions that are inactive against
ideal state.
+ private final ScheduledExecutorService _scheduledExecutor =
Executors.newScheduledThreadPool(20);
Review Comment:
Do we need so many threads? I feel 1 thread might be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
