swaminathanmanish commented on code in PR #11907:
URL: https://github.com/apache/pinot/pull/11907#discussion_r1376718836
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/TimeValidationTransformer.java:
##########
@@ -103,6 +103,7 @@ public GenericRow transform(GenericRow record) {
if (_continueOnError) {
LOGGER.debug(errorMessage);
record.putValue(_timeColumnName, null);
+ record.putValue(GenericRow.INCOMPLETE_RECORD_KEY, true);
Review Comment:
Im fine with this change, but its better to check with the authors on why
they did it this way.
So with this change, we will skip the record (in NullValueTransformer),
instead of assigning currentTime right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
