egalpin commented on code in PR #11886:
URL: https://github.com/apache/pinot/pull/11886#discussion_r1373877186
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/GroupByPlanNode.java:
##########
@@ -75,35 +70,10 @@ private GroupByOperator buildNonFilteredGroupByPlan() {
FilterPlanNode filterPlanNode = new FilterPlanNode(_indexSegment,
_queryContext);
BaseFilterOperator filterOperator = filterPlanNode.run();
-
- // Use star-tree to solve the query if possible
- List<StarTreeV2> starTrees = _indexSegment.getStarTrees();
- if (starTrees != null && !_queryContext.isSkipStarTree()) {
Review Comment:
Note: this PR would introduce a behaviour change (bugfix?) where
`AggregationPlanNode` included an additional predicate to check if null
handling is enabled before allowing use of StarTree index to solve the query.
This PR consolidates this logic to one method within OperatorUtils.java, where
the null handling predicate is kept such that both GroupByPlanNode and
AggregationPlanNode will ensure null handling is disabled before allowing use
of StarTree index.
> if (starTrees != null && !_queryContext.isSkipStarTree() &&
!_queryContext.isNullHandlingEnabled()) {
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
