Jackie-Jiang commented on code in PR #11869:
URL: https://github.com/apache/pinot/pull/11869#discussion_r1373537750
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java:
##########
@@ -41,6 +41,7 @@ public class SegmentsValidationAndRetentionConfig extends
BaseJsonConfig {
private String _schemaName;
private String _timeColumnName;
private TimeUnit _timeType;
+ @Deprecated // Use SegmentAssignmentConfig instead
private String _segmentAssignmentStrategy;
Review Comment:
Also deprecate the getter
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -73,8 +72,9 @@ public class TableConfigBuilder {
@Deprecated
private String _segmentPushFrequency;
@Deprecated
- private String _segmentPushType = DEFAULT_SEGMENT_PUSH_TYPE;
Review Comment:
This change can be backward incompatible because current code assume it is
not `null` without this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
