Jackie-Jiang commented on PR #11744: URL: https://github.com/apache/pinot/pull/11744#issuecomment-1778822449
I applied a commit to introduce the `AggregationSpec` and revert the changes in `AggregationFunctionColumnPair` because that is used to match the functions at query time. Changed the `TreeSet<AggregationFunctionColumnPair>` to `TreeMap<AggregationFunctionColumnPair, AggregationSpec>` so that we can use `keySet()` to achieve the same behavior. Other changes: - Removed the duplicate config check because I feel user might config both fields, and we prioritize on `aggregationConfigs` over `functionColumnPairs` - Simplified the test changes to use a random compression codec in `BaseStarTreeV2Test`. Please take a look and let me know if you have concern about the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
