abhioncbr commented on code in PR #11816:
URL: https://github.com/apache/pinot/pull/11816#discussion_r1366367041
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionUtils.java:
##########
@@ -126,7 +126,6 @@ private FunctionUtils() {
put(float[].class, ColumnDataType.FLOAT_ARRAY);
put(double[].class, ColumnDataType.DOUBLE_ARRAY);
put(String[].class, ColumnDataType.STRING_ARRAY);
- put(Object.class, ColumnDataType.OBJECT);
Review Comment:
Removing this leads it to return `null`; hence, we set the `_resultMetadata`
in `ScalarTransformationFunction` or in `PostAggregationFunction` as String.
Eventually, it fails while evaluating the valueblock.
@Jackie-Jiang / @walterddr do you guys think determining the
`_resultMetadata` based on the transformation function result makes sense like
we are doing in
[CaseTransformFunction](https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java#L105)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
