gortiz opened a new pull request, #11824: URL: https://github.com/apache/pinot/pull/11824
This is PR that has the intention of implementing column level nullability, as explained in https://github.com/apache/pinot/issues/10381. Current status: - [x] Add nullability to Schema.FieldSpec. - [x] Use Schema.FieldSpec.getNullable to inform Calcite about actual column nullability. - [ ] Use Schema.FieldSpec.getNullable to somehow support column level nullability in V1. * To modify V1 to actually support column level nullability seems a long task * What we are going to do in the first place is to: - [ ] Modify the leafs of the execution tree to ignore the actual null value vector for columns whose Schema.FieldSpec.getNullable is false. Instead an empty null vector will be returned. - [x] Keep the rest of the V1 engine stable, so the new null vectors will be calculated for transformations applied to non nullable colums. But given these columns will produce values that are not actually null, transformations should be also not null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
