Jackie-Jiang commented on code in PR #11785:
URL: https://github.com/apache/pinot/pull/11785#discussion_r1358990509
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -700,19 +699,24 @@ public ServerReloadControllerJobStatusResponse
getReloadJobStatus(
serverReloadControllerJobStatusResponse.setTotalServersQueried(serverUrls.size());
serverReloadControllerJobStatusResponse.setTotalServerCallsFailed(serviceResponse._failedResponseCount);
+ // Merge all server responses.
+ List<String> pendingSegments = new ArrayList<>();
+ int successCount = 0;
for (Map.Entry<String, String> streamResponse :
serviceResponse._httpResponses.entrySet()) {
String responseString = streamResponse.getValue();
try {
ServerReloadControllerJobStatusResponse response =
JsonUtils.stringToObject(responseString,
ServerReloadControllerJobStatusResponse.class);
- serverReloadControllerJobStatusResponse.setSuccessCount(
- serverReloadControllerJobStatusResponse.getSuccessCount() +
response.getSuccessCount());
+ successCount += response.getSuccessCount();
+ pendingSegments.addAll(response.getPendingSegments());
Review Comment:
This will throw NPE when server is running the old version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
