walterddr commented on code in PR #11787:
URL: https://github.com/apache/pinot/pull/11787#discussion_r1357079898
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -665,7 +665,7 @@ public ServerReloadControllerJobStatusResponse
getReloadJobStatus(
serverToSegments.put(server, segmentList);
});
} else {
- serverToSegments =
_pinotHelixResourceManager.getServerToSegmentsMap(tableNameWithType);
+ serverToSegments =
_pinotHelixResourceManager.getServerToOnlineSegmentsMap(tableNameWithType);
Review Comment:
i was actually thinking whether we should do 4 counts
1. zk segment_cnt
2. zk online_segment_cnt
3. SUM(segment_cnt) from each server
4. SUM(success_cnt) from each server
the logic to return success or failure will be based off 3==4, but if 3 != 2
we should do a warning. thoughts @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
