davecromberge commented on code in PR #11774:
URL: https://github.com/apache/pinot/pull/11774#discussion_r1355088458
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -515,23 +518,23 @@ public VarianceTuple deserialize(ByteBuffer byteBuffer) {
}
};
- public static final ObjectSerDe<PinotFourthMoment>
PINOT_FOURTH_MOMENT_OBJECT_SER_DE
- = new ObjectSerDe<PinotFourthMoment>() {
- @Override
- public byte[] serialize(PinotFourthMoment value) {
- return value.serialize();
- }
+ public static final ObjectSerDe<PinotFourthMoment>
PINOT_FOURTH_MOMENT_OBJECT_SER_DE =
+ new ObjectSerDe<PinotFourthMoment>() {
+ @Override
+ public byte[] serialize(PinotFourthMoment value) {
+ return value.serialize();
+ }
- @Override
- public PinotFourthMoment deserialize(byte[] bytes) {
- return PinotFourthMoment.fromBytes(bytes);
- }
+ @Override
+ public PinotFourthMoment deserialize(byte[] bytes) {
+ return PinotFourthMoment.fromBytes(bytes);
+ }
- @Override
- public PinotFourthMoment deserialize(ByteBuffer byteBuffer) {
- return PinotFourthMoment.fromBytes(byteBuffer);
- }
- };
+ @Override
+ public PinotFourthMoment deserialize(ByteBuffer byteBuffer) {
+ return PinotFourthMoment.fromBytes(byteBuffer);
+ }
+ };
Review Comment:
I am happy to remove the additional formatting - I used the [recommended
settings](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#intellij)
for IntelliJ and reformatted every file I touched accordingly. This does not
seem to be enforced on CI so perhaps it is unnecessary.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
