itschrispeck commented on code in PR #11739:
URL: https://github.com/apache/pinot/pull/11739#discussion_r1353529541
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/JsonIndexReader.java:
##########
@@ -31,4 +33,13 @@ public interface JsonIndexReader extends IndexReader {
* Returns the matching document ids for the given filter.
*/
MutableRoaringBitmap getMatchingDocIds(String filterString);
+
+ /**
+ * For a JSON key and array of docIds, returns the corresponding values for
each docId.
+ * This method takes a map as input which is used to cache the posting list
for each dictId/value. It will be
+ * populated if empty, otherwise it will be used to avoid reading and
converting the posting list of flattened docs
+ *
+ * @return String[] where String[i] is the value for docIds[i]
+ */
+ String[] getValuesForKeyAndDocs(String key, int[] docIds, Map<Object,
RoaringBitmap> cache);
Review Comment:
Ah good point, I had changed it to Object -> Bitmap since the mutable index
used a String key, but context would make this easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
