t0mpere commented on code in PR #11744:
URL: https://github.com/apache/pinot/pull/11744#discussion_r1352891714


##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/StarTreeIndexConfig.java:
##########
@@ -34,6 +35,8 @@ public class StarTreeIndexConfig extends BaseJsonConfig {
   private final List<String> _skipStarNodeCreationForDimensions;
   // Function column pairs with delimiter "__", e.g. SUM__col1, MAX__col2, 
COUNT__*
   private final List<String> _functionColumnPairs;
+  // Compression mapping for function column pairs
+  private final Properties _functionColumnPairsConfig;

Review Comment:
   I took the liberty of implementing a new `BaseJsonConfig` to handle this. 
It's backward compatible and potentially could substitute the `function__col` 
format making it more extendible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to