walterddr commented on code in PR #11726:
URL: https://github.com/apache/pinot/pull/11726#discussion_r1344425902
##########
pinot-common/src/test/java/org/apache/pinot/common/function/FunctionDefinitionRegistryTest.java:
##########
@@ -47,10 +47,8 @@ public class FunctionDefinitionRegistryTest {
// Scalar function
"scalar",
// Functions without scalar function counterpart as of now
- // TODO: Revisit this list when we add scalar function for these
functions
- "arraylength", "arrayaverage", "arraymin", "arraymax", "arraysum",
- "valuein", "mapvalue", "inidset", "lookup", "groovy",
- "timeconvert", "datetimeconvert", "jsonextractscalar", "jsonextractkey",
"clpdecode",
+ "arraylength", "arrayaverage", "arraymin", "arraymax", "arraysum",
"clpdecode", "groovy",
Review Comment:
other than the ignored list here, all other functions (including their
alternative naming are registered in FunctionRegistry (e.g. has correspondent
in ScalarFunction impl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
