Jackie-Jiang commented on code in PR #11650:
URL: https://github.com/apache/pinot/pull/11650#discussion_r1343231656
##########
pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/creator/name/SimpleSegmentNameGeneratorTest.java:
##########
@@ -83,4 +86,19 @@ public void
testWithMalFormedTableNameSegmentNamePostfixTimeValue() {
assertEquals(e.getMessage(), "Invalid partial or full segment name:
12|34");
}
}
+
+ @Test
+ public void testWithexcludeTimeInSegmentName() {
Review Comment:
```suggestion
public void testWithExcludeTimeInSegmentName() {
```
##########
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/BatchConfig.java:
##########
@@ -190,6 +193,10 @@ public boolean isAppendUUIDToSegmentName() {
return _appendUUIDToSegmentName;
}
+ public boolean isExcludeTimeFromSegmentName() {
+ return _excludeTimeFromSegmentName;
+ }
Review Comment:
```suggestion
public boolean isExcludeTimeInSegmentName() {
return _excludeTimeInSegmentName;
}
```
##########
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/BatchConfig.java:
##########
@@ -51,6 +51,7 @@ public class BatchConfig {
private final String _segmentNamePostfix;
private final boolean _excludeSequenceId;
private final boolean _appendUUIDToSegmentName;
+ private final boolean _excludeTimeFromSegmentName;
Review Comment:
```suggestion
private final boolean _excludeTimeInSegmentName;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
