Jackie-Jiang commented on code in PR #11715:
URL: https://github.com/apache/pinot/pull/11715#discussion_r1343141946
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java:
##########
@@ -48,15 +48,13 @@ public static void setExecutionStatistics(BaseResultsBlock
resultsBlock, List<Op
if (executionStatistics.getNumDocsScanned() > 0) {
numSegmentsMatched++;
}
- // TODO: Check all operators and properly implement the getIndexSegment
and remove this exception handling
- try {
- if (operator.getIndexSegment() instanceof MutableSegment) {
- numConsumingSegmentsProcessed += 1;
- if (executionStatistics.getNumDocsScanned() > 0) {
- numConsumingSegmentsMatched++;
- }
+
+ // TODO: Check all operators and properly implement the getIndexSegment.
+ if (operator.getIndexSegment() != null && operator.getIndexSegment()
instanceof MutableSegment) {
Review Comment:
```suggestion
if (operator.getIndexSegment() instanceof MutableSegment) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
