klsince commented on code in PR #11720:
URL: https://github.com/apache/pinot/pull/11720#discussion_r1342946086
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -224,6 +224,45 @@ public void setUp()
// Wait for all documents loaded
waitForAllDocsLoaded(600_000L);
+
+ // Try to reload all the segments with force download from the controller
URI.
+ reloadAllSegments(TEST_UPDATED_INVERTED_INDEX_QUERY, true,
getCountStarResult());
+
+ // Try to upload all the segments again with force download from the
controller URI.
+ try {
+ uploadSegments(getTableName(), tarDirs);
+ } catch (Exception e) {
+ // If enableParallelPushProtection is enabled and the same segment is
uploaded concurrently, we could get one
+ // of the two exception - 409 conflict of the second call enters
ProcessExistingSegment ; segmentZkMetadata
+ // creation failure if both calls entered ProcessNewSegment. In/such
cases ensure that we upload all the
+ // segments again/to ensure that the data is setup correctly.
Review Comment:
looks like the comment is copied from L205 above, but there seems some typos
`In/such... again/to...`
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -224,6 +224,45 @@ public void setUp()
// Wait for all documents loaded
waitForAllDocsLoaded(600_000L);
+
+ // Try to reload all the segments with force download from the controller
URI.
+ reloadAllSegments(TEST_UPDATED_INVERTED_INDEX_QUERY, true,
getCountStarResult());
+
+ // Try to upload all the segments again with force download from the
controller URI.
+ try {
+ uploadSegments(getTableName(), tarDirs);
+ } catch (Exception e) {
+ // If enableParallelPushProtection is enabled and the same segment is
uploaded concurrently, we could get one
+ // of the two exception - 409 conflict of the second call enters
ProcessExistingSegment ; segmentZkMetadata
+ // creation failure if both calls entered ProcessNewSegment. In/such
cases ensure that we upload all the
+ // segments again/to ensure that the data is setup correctly.
+ assertTrue(e.getMessage().contains("Another segment upload is in
progress for segment") || e.getMessage()
+ .contains("Failed to update ZK metadata for segment") ||
e.getMessage()
+ .contains("java.nio.file.FileAlreadyExistsException"),
e.getMessage());
Review Comment:
this check on `FileAlreadyExists..` is different what's used above L210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
