chenboat commented on code in PR #11604:
URL: https://github.com/apache/pinot/pull/11604#discussion_r1336496752
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java:
##########
@@ -106,8 +106,11 @@ private void addFlattenedRecords(List<Map<String, String>>
records) {
// Put both key and key-value into the posting list. Key is useful for
checking if a key exists in the json.
String key = entry.getKey();
_postingListMap.computeIfAbsent(key, k -> new
RoaringBitmap()).add(_nextFlattenedDocId);
- String keyValue = key + JsonIndexCreator.KEY_VALUE_SEPARATOR +
entry.getValue();
- _postingListMap.computeIfAbsent(keyValue, k -> new
RoaringBitmap()).add(_nextFlattenedDocId);
+ int length = _jsonIndexConfig.getMaxValueLength();
Review Comment:
@Jackie-Jiang This PR is orthogonal to the group by feature we brought
earlier. Truncating the string length in json index itself is an improvement
over the current Json index implementation. String has maxLength limit in
Pinot today but string in Json does not have that. This is the improvement this
PR is about. A json string overall can be as long as 1M bytes in our system. We
can not have string value in it to have such a length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
