walterddr commented on issue #11651: URL: https://github.com/apache/pinot/issues/11651#issuecomment-1734016088
let me dig deeper into the problem. IMO there's 2 aspect of this issue: 1. does multi-stage engine support pre-distributed dim-tables --> i need to double check and see the dispatch logic to handle pre-distributed table 2. does multi-stage engine support LOOKUP syntax --> the answer is no because multi-stage engine supports standard SQL way to express this: ``` SELECT localCol, LOOKUP('foreignTbl', 'foreignCol', 'foreignKey', localKey) FROM tbl ``` is equivalent to ``` SELECT localCol, foreignCol FROM tbl LEFT JOIN foreignTbl ON localKey = foreignKey ``` 3. should we provide an upgrade / backward-compatible transition --> i think it is yes but this, along with SUBQUERY/IDSET and other V1 only functionalities, should be handle systematically. several ideas i can think of: a. a standalone query rewriter that translates old syntax to new b. automatic fallback to v1 syntax (default with v2) until the next release c. automatic fall-forward to v2 syntax (default with v1) until the next release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org