Jackie-Jiang commented on code in PR #11555:
URL: https://github.com/apache/pinot/pull/11555#discussion_r1324077321
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java:
##########
@@ -74,6 +76,85 @@ public static int arrayIndexOfString(String[] values, String
valueToFind) {
return ArrayUtils.indexOf(values, valueToFind);
}
+ @ScalarFunction
+ public static int[] arrayIndexOfAllInt(int[] value, int valueToFind) {
+ List<Integer> indices = new ArrayList<>();
Review Comment:
Let's use `IntArrayList` from `it.unimi.dsi.fastutil.ints`, then we can use
`list.toIntArray()`
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java:
##########
@@ -74,6 +76,85 @@ public static int arrayIndexOfString(String[] values, String
valueToFind) {
return ArrayUtils.indexOf(values, valueToFind);
}
+ @ScalarFunction
+ public static int[] arrayIndexOfAllInt(int[] value, int valueToFind) {
Review Comment:
Consider naming it `arrayIndexesOfInt()` (align with the method name in
`ArrayUtils`), same for other methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
