rajagopr commented on code in PR #11581:
URL: https://github.com/apache/pinot/pull/11581#discussion_r1323908431
##########
pinot-plugins/pinot-input-format/pinot-csv/src/test/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReaderTest.java:
##########
@@ -538,8 +538,9 @@ private List<GenericRow> readCSVRecords(File dataFile,
CSVRecordReaderConfig rea
try (CSVRecordReader recordReader = new CSVRecordReader()) {
recordReader.init(dataFile, null, readerConfig);
+ GenericRow reuse = new GenericRow();
while (recordReader.hasNext()) {
- GenericRow genericRow = recordReader.next();
+ GenericRow genericRow = recordReader.next(reuse);
Review Comment:
addressed – added coverage for both.
##########
pinot-plugins/pinot-input-format/pinot-csv/src/test/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReaderTest.java:
##########
@@ -538,8 +538,9 @@ private List<GenericRow> readCSVRecords(File dataFile,
CSVRecordReaderConfig rea
try (CSVRecordReader recordReader = new CSVRecordReader()) {
recordReader.init(dataFile, null, readerConfig);
+ GenericRow reuse = new GenericRow();
while (recordReader.hasNext()) {
- GenericRow genericRow = recordReader.next();
+ GenericRow genericRow = recordReader.next(reuse);
Review Comment:
addressed – added coverage for both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
