wirybeaver commented on code in PR #10815:
URL: https://github.com/apache/pinot/pull/10815#discussion_r1323785121
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -239,6 +239,14 @@ public void cleanupSegmentCountGauge(final String
resource) {
removeGauge(resource, ValidationMetricName.SEGMENT_COUNT);
}
+ public void updateTmpSegmentCountGauge(final String resource, final long
tmpSegmentCount) {
Review Comment:
```
public enum ValidationMetricName {
MISSING_SEGMENT_COUNT("missingSegmentCount"),
OFFLINE_SEGMENT_DELAY_HOURS("offlineSegmentDelayHours"),
LAST_PUSH_TIME_DELAY_HOURS("lastPushTimeDelayHours"),
TOTAL_DOCUMENT_COUNT("TotalDocumentCount"),
NON_CONSUMING_PARTITION_COUNT("NonConsumingPartitionCount"),
SEGMENT_COUNT("SegmentCount"),
DELETED_TMP_SEGMENT_COUNT("DeletedTmpSegmentCount");
```
It seems that all count metrics are using Gauge
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -239,6 +239,14 @@ public void cleanupSegmentCountGauge(final String
resource) {
removeGauge(resource, ValidationMetricName.SEGMENT_COUNT);
}
+ public void updateTmpSegmentCountGauge(final String resource, final long
tmpSegmentCount) {
Review Comment:
Shall we use Count?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
