ege-st commented on PR #11496: URL: https://github.com/apache/pinot/pull/11496#issuecomment-1716354398
> > has less unknowns > > Could you eleborate your concern here? I think the tests/heap dump/graphs show that we recover deterministically and the direct buffers are deallocated. The concerns that @soumitra-st and I had when working on a fix was that neither of us were Netty experts and weren't sure how well Netty would behave if it get a direct memory OOM and we kept running: e.g., we weren't sure if there would be a memory leak or some other type of resource leak, or if there might be unknown side effects for in flight queries, or what other effects within the Broker there might be. So, we erred towards treating this as an unrecoverable fault and triggered a shutdown, we felt this was the safest and easiest solution because shutdowns are a normal operation and would be the least likely to create unexpected issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
