rajagopr commented on PR #11540: URL: https://github.com/apache/pinot/pull/11540#issuecomment-1714880226
> Synced up offline. This PR looks good to me. > > Follow up items: > > 1. Check if removing the header delimiter validation gets correctly processed after removing it. Consider the following file and the delimiter being set as `,`. The header has an incorrect delimiter. ``` id;firstName;lastName 100,john,doe 101,jane,doe ``` In this case, the records would be interpreted as follows and the previous validation would have helped. ``` record1 [id;firstName;lastName --> 100] record2 [id;firstName;lastName --> 101] ``` While an error is not reported to the user, the user has the option to pass in the correct header. > 2. Look into the test code for the case where delimiter config & actual delimiter in csv are different. When the set delimiter is different from the actual delimiter the entire line would be read as a single field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
