abhioncbr commented on PR #11510: URL: https://github.com/apache/pinot/pull/11510#issuecomment-1709286845
> Hey @abhioncbr I'm not sure this is a good approach in terms of maintainability: > > * this makes the pom very complex > * dependencies in `common` and `core` may change. I fear clients exclusion will not be updated accordingly > * clients developer may be tempted to use classes of the `common` and `core` package that won't work at runtime because some dependencies will have been excluded > > I'm not a maintainer of pinot so I don't have a strong opinion but I think it'd be better to first discuss potential solutions in the issue. Thanks for the feedback, @cyrilou242, I agree this is not a good solution, and you already outlined the drawbacks. However, in my understanding, we don't have much of options here, One is to add the exclusion, and the other is either to copy the used code into the java client itself or create a separate submodule and move the dependency code into the new submodule. Please suggest if you have some other options in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
