This is an automated email from the ASF dual-hosted git repository.

xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new cd32d16f60 enable some previously failed tests (#11516)
cd32d16f60 is described below

commit cd32d16f6002bf420296d5de20da2731e055084b
Author: Haitao Zhang <[email protected]>
AuthorDate: Wed Sep 6 07:12:16 2023 -0700

    enable some previously failed tests (#11516)
    
    Co-authored-by: Xiang Fu <[email protected]>
---
 .../tests/custom/FloatingPointDataTypeTest.java         | 17 ++++++++---------
 .../tests/tpch/TPCHQueryIntegrationTest.java            |  3 +--
 2 files changed, 9 insertions(+), 11 deletions(-)

diff --git 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/FloatingPointDataTypeTest.java
 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/FloatingPointDataTypeTest.java
index 7e1f94acca..7842eca856 100644
--- 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/FloatingPointDataTypeTest.java
+++ 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/FloatingPointDataTypeTest.java
@@ -153,28 +153,27 @@ public class FloatingPointDataTypeTest extends 
CustomDataQueryClusterIntegration
         {MET_DOUBLE_SORTED + " > 0.05", "4"},
         {MET_DOUBLE_SORTED + " = 0.05", "1"},
         {MET_DOUBLE_SORTED + " < 0.05", "5"},
-        // TODO: Fix the issue with float data type
-        // {MET_FLOAT_SORTED + " > 0.05", "4"},
+        {MET_FLOAT_SORTED + " > 0.05", "4"},
         {MET_FLOAT_SORTED + " = 0.05", "1"},
-        // {MET_FLOAT_SORTED + " < 0.05", "5"},
+        {MET_FLOAT_SORTED + " < 0.05", "5"},
         {MET_DOUBLE_UNSORTED + " > 0.05", "4"},
         {MET_DOUBLE_UNSORTED + " = 0.05", "1"},
         {MET_DOUBLE_UNSORTED + " < 0.05", "5"},
-        // {MET_FLOAT_UNSORTED + " > 0.05", "4"},
+        {MET_FLOAT_UNSORTED + " > 0.05", "4"},
         {MET_FLOAT_UNSORTED + " = 0.05", "1"},
-        // {MET_FLOAT_UNSORTED + " < 0.05", "5"},
+        {MET_FLOAT_UNSORTED + " < 0.05", "5"},
         {MET_DOUBLE_SORTED_NO_DIC + " > 0.05", "4"},
         {MET_DOUBLE_SORTED_NO_DIC + " = 0.05", "1"},
         {MET_DOUBLE_SORTED_NO_DIC + " < 0.05", "5"},
-        // {MET_FLOAT_SORTED_NO_DIC + " > 0.05", "4"},
+        {MET_FLOAT_SORTED_NO_DIC + " > 0.05", "4"},
         {MET_FLOAT_SORTED_NO_DIC + " = 0.05", "1"},
-        // {MET_FLOAT_SORTED_NO_DIC + " < 0.05", "5"},
+        {MET_FLOAT_SORTED_NO_DIC + " < 0.05", "5"},
         {MET_DOUBLE_UNSORTED_NO_DIC + " > 0.05", "4"},
         {MET_DOUBLE_UNSORTED_NO_DIC + " = 0.05", "1"},
         {MET_DOUBLE_UNSORTED_NO_DIC + " < 0.05", "5"},
-        // {MET_FLOAT_UNSORTED_NO_DIC + " > 0.05", "4"},
+        {MET_FLOAT_UNSORTED_NO_DIC + " > 0.05", "4"},
         {MET_FLOAT_UNSORTED_NO_DIC + " = 0.05", "1"},
-        // {MET_FLOAT_UNSORTED_NO_DIC + " < 0.05", "5"},
+        {MET_FLOAT_UNSORTED_NO_DIC + " < 0.05", "5"},
     };
     for (String[] faec : filterAndExpectedCount) {
       String filter = faec[0];
diff --git 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/tpch/TPCHQueryIntegrationTest.java
 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/tpch/TPCHQueryIntegrationTest.java
index 020ff6581c..d4d74d7840 100644
--- 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/tpch/TPCHQueryIntegrationTest.java
+++ 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/tpch/TPCHQueryIntegrationTest.java
@@ -55,10 +55,9 @@ import org.testng.annotations.Test;
 public class TPCHQueryIntegrationTest extends BaseClusterIntegrationTest {
   private static final int NUM_TPCH_QUERIES = 24;
 
-  // Pinot query 6 fails due to mismatch results.
   // Pinot queries 15, 16, 17 fail due to lack of support for views.
   // Pinot queries 23 fail due to java heap space problem or timeout.
-  private static final Set<Integer> EXEMPT_QUERIES = ImmutableSet.of(6, 15, 
16, 17, 23);
+  private static final Set<Integer> EXEMPT_QUERIES = ImmutableSet.of(15, 16, 
17, 23);
 
   @BeforeClass
   public void setUp()


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to