zhtaoxiang commented on PR #11478: URL: https://github.com/apache/pinot/pull/11478#issuecomment-1702278073
> > > Maybe we should always use `BigDecimal` to perform the comparison and set value for floating-point numbers > > > > > > Thanks for the suggestion! That may be a good idea for the longer term. > > > > 1. In the short team, this PR can be a quick fix > > 2. to always use BigDecimal to perform the comparison, (1) we need more thorough tests (2) we also need to benchmark the performance to see if there is any performance issue > > The reason why I raised this is because a lot of tests failed.. Those failed tests are the unit tests I forgot to fix, and not too many 😛 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
