Jackie-Jiang commented on PR #11458: URL: https://github.com/apache/pinot/pull/11458#issuecomment-1698475207
> Here we seem to be saying that even if snapshot exists for just 1 uploaded segment, we return true. M motivation to ensure all segments had snapshot was to make sure the preload doesn't break in the future due to some unexpected changes in the snapshotting mechanism. > > We should atleast ensure all uploaded segments have snapshots We do ensure all uploaded segments have snapshots. If any of them does not have snapshot, we return false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
