shenyu0127 commented on PR #11444: URL: https://github.com/apache/pinot/pull/11444#issuecomment-1696679544
> If would be good to add a test to `CaseTransformFunctionTest` which uses a query "SELECT CASE WHEN xx THEN xx ELSE NULL" and assert the query results to exercise the modified code paths. Did you add a test? The rest looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
