jadami10 opened a new pull request, #11443: URL: https://github.com/apache/pinot/pull/11443
This is arguable a `fix` to metrics in the `RealtimeConsumptionRateManager.java`. Rather than emit metrics every time we call `.throttle`, only emit these metrics when throttling is enabled. I see our servers emit order of magnitude above 100 when they first start up and catch up at an unbounded rate. This makes it hard to understand the chart and write detectors on this metric. We could also introduce 2 metrics for "quota utilization with throttling on" vs "quota utilization with throttling off", but that feels somewhat counterintuitive to emit the utilization metric when throttling isn't even doing anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
