[pinot] branch master updated: Fix RawStringDistinctExecutor integer overflow (#11403)

[xiangfu]

This is an automated email from the ASF dual-hosted git repository.

xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new e8da9eb053 Fix RawStringDistinctExecutor integer overflow (#11403)
e8da9eb053 is described below

commit e8da9eb0536529e2e6d837d6291a2fe8f9ce5cd1
Author: Saurabh Dubey <saurabhd...@gmail.com>
AuthorDate: Tue Aug 22 21:46:16 2023 +0530

    Fix RawStringDistinctExecutor integer overflow (#11403)
---
 .../distinct/raw/BaseRawBigDecimalSingleColumnDistinctExecutor.java     | 2 +-
 .../query/distinct/raw/BaseRawBytesSingleColumnDistinctExecutor.java    | 2 +-
 .../query/distinct/raw/BaseRawStringSingleColumnDistinctExecutor.java   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawBigDecimalSingleColumnDistinctExecutor.java
 
b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawBigDecimalSingleColumnDistinctExecutor.java
index b1ffe77602..8d06d2fe7c 100644
--- 
a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawBigDecimalSingleColumnDistinctExecutor.java
+++ 
b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawBigDecimalSingleColumnDistinctExecutor.java
@@ -68,7 +68,7 @@ public abstract class 
BaseRawBigDecimalSingleColumnDistinctExecutor implements D
     if (_hasNull) {
       records.add(new Record(new Object[]{null}));
     }
-    assert records.size() <= _limit + 1;
+    assert (records.size() - _limit) <= 1;
     return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
   }
 
diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawBytesSingleColumnDistinctExecutor.java
 
b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawBytesSingleColumnDistinctExecutor.java
index 5babb84c41..18f72482e3 100644
--- 
a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawBytesSingleColumnDistinctExecutor.java
+++ 
b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawBytesSingleColumnDistinctExecutor.java
@@ -68,7 +68,7 @@ abstract class BaseRawBytesSingleColumnDistinctExecutor 
implements DistinctExecu
     if (_hasNull) {
       records.add(new Record(new Object[]{null}));
     }
-    assert records.size() <= _limit + 1;
+    assert (records.size() - _limit) <= 1;
     return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
   }
 
diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawStringSingleColumnDistinctExecutor.java
 
b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawStringSingleColumnDistinctExecutor.java
index 7b85a9a648..acbd271bd3 100644
--- 
a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawStringSingleColumnDistinctExecutor.java
+++ 
b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawStringSingleColumnDistinctExecutor.java
@@ -67,7 +67,7 @@ abstract class BaseRawStringSingleColumnDistinctExecutor 
implements DistinctExec
     if (_hasNull) {
       records.add(new Record(new Object[]{null}));
     }
-    assert records.size() <= _limit + 1;
+    assert (records.size() - _limit) <= 1;
     return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
   }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org