Jackie-Jiang commented on code in PR #11341:
URL: https://github.com/apache/pinot/pull/11341#discussion_r1293084830
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -169,6 +170,78 @@ public void processSqlQueryPost(String query, @Suspended
AsyncResponse asyncResp
}
}
+ @GET
+ @ManagedAsync
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("query")
+ @ApiOperation(value = "Querying pinot using MultiStage Query Engine")
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Query response"),
+ @ApiResponse(code = 500, message = "Internal Server Error")
+ })
+ @ManualAuthorization
+ public void processSqlWithMultiStageQueryEngineGet(
+ @ApiParam(value = "Query", required = true) @QueryParam("sql") String
query,
+ @ApiParam(value = "Trace enabled") @QueryParam(Request.TRACE) String
traceEnabled,
+ @ApiParam(value = "Debug options") @QueryParam(Request.DEBUG_OPTIONS)
String debugOptions,
Review Comment:
Debug options is already deprecated. Let's not add them in the new API.
For `trace`, I'm not sure if it can be added as a query option. If so, we
can also remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
