Jackie-Jiang commented on code in PR #11277:
URL: https://github.com/apache/pinot/pull/11277#discussion_r1288019350
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/sql/SqlQueryExecutor.java:
##########
@@ -103,7 +104,7 @@ public BrokerResponse executeDMLStatement(SqlNodeAndOptions
sqlNodeAndOptions,
List<Object[]> rows = new ArrayList<>();
tableToTaskIdMap.forEach((key, value) -> rows.add(new Object[]{key,
value}));
result.setResultTable(new ResultTable(statement.getResultSchema(),
rows));
- } catch (IOException e) {
+ } catch (IOException | HttpException e) {
Review Comment:
We should just catch `Exception` here (including RuntimeException)
##########
pinot-common/src/main/java/org/apache/pinot/common/http/MultiHttpRequestResponse.java:
##########
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.http;
+
+import java.net.URI;
+import org.apache.http.client.methods.CloseableHttpResponse;
+
+
+public class MultiHttpRequestResponse implements AutoCloseable {
+ private final URI _uri;
+ private final int _responseStatusCode;
+ private final String _responseContent;
Review Comment:
These 2 fields are part of the response. Consider only passing in the
response and get them on the fly
##########
pinot-common/src/main/java/org/apache/pinot/common/http/MultiHttpRequestResponse.java:
##########
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.http;
+
+import java.net.URI;
+import org.apache.http.client.methods.CloseableHttpResponse;
+
+
+public class MultiHttpRequestResponse implements AutoCloseable {
+ private final URI _uri;
+ private final int _responseStatusCode;
+ private final String _responseContent;
+ private final CloseableHttpResponse _response;
+
+ public MultiHttpRequestResponse(URI uri, int responseStatusCode,
+ String responseContent, CloseableHttpResponse response) {
+ _uri = uri;
+ _response = response;
+ _responseStatusCode = responseStatusCode;
+ _responseContent = responseContent;
+ }
+
+ public URI getURI() {
+ return _uri;
+ }
+
+ public int getResponseStatusCode() {
+ return _responseStatusCode;
+ }
+
+ public String getResponseContent() {
+ return _responseContent;
+ }
+
+ @Override
+ public void close() throws Exception {
Review Comment:
(code format) This file doesn't follow Pinot Style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
