This is an automated email from the ASF dual-hosted git repository.

mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new bc4a225428 Make PinotTableRestletResourceTest java8 compatible (#11287)
bc4a225428 is described below

commit bc4a2254286338c4051bcd046a22c425bc908fbc
Author: Dino Occhialini <dino.occhial...@gmail.com>
AuthorDate: Mon Aug 7 15:02:07 2023 -0700

    Make PinotTableRestletResourceTest java8 compatible (#11287)
    
    This commit fixes java8 build compatibility that is broken in #11017
    
    Specifically, `Map.of` is only available in java 9+.
    
    In this case, this code:
    
    ```java
    TableConfigBuilder(TableType.REALTIME)
          .setStreamConfigs(Map.of("stream.type", "foo", "consumer.type", 
"lowlevel"));
    ```
    
    Is actually not used since we are later calling the following in setup:
    
    ```java
    StreamConfig streamConfig = 
FakeStreamConfigUtils.getDefaultLowLevelStreamConfigs();
    _realtimeBuilder...setStreamConfigs(streamConfig.getStreamConfigsMap());
    ```
---
 .../org/apache/pinot/controller/api/PinotTableRestletResourceTest.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotTableRestletResourceTest.java
 
b/pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotTableRestletResourceTest.java
index f0d17de26b..7203da3819 100644
--- 
a/pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotTableRestletResourceTest.java
+++ 
b/pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotTableRestletResourceTest.java
@@ -58,8 +58,7 @@ public class PinotTableRestletResourceTest extends 
ControllerTest {
   private static final String OFFLINE_TABLE_NAME = "testOfflineTable";
   private static final String REALTIME_TABLE_NAME = "testRealtimeTable";
   private final TableConfigBuilder _offlineBuilder = new 
TableConfigBuilder(TableType.OFFLINE);
-  private final TableConfigBuilder _realtimeBuilder = new 
TableConfigBuilder(TableType.REALTIME)
-      .setStreamConfigs(Map.of("stream.type", "foo", "consumer.type", 
"lowlevel"));
+  private final TableConfigBuilder _realtimeBuilder = new 
TableConfigBuilder(TableType.REALTIME);
   private String _createTableUrl;
 
   @BeforeClass


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to