gortiz commented on PR #11264: URL: https://github.com/apache/pinot/pull/11264#issuecomment-1667415680
There are two different issues: - We have JsonUtils several times in the classpath with the same package. Luckily, the correct one is loaded first. - The plugins shade jackson using their package prefix. That means that when they call public spi that use jackson, they use their own package. For example, they call `<apache pinot package>.JsonUtils.stringToObject(String, <their-package-prefix>.TypeReference)`, which does not exist. That later problem is the one that affected us. The problem here is that by adding jackson arguments and results to our spi methods, we are indicating that jackson should not be shaded, when in fact jackson is one the main package we want to shade due to incompatibilities in the classpath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
